I’ve spent the last couple of weeks getting infrastructure-live-acme up and running - thanks @jim for all your help!
It’s awesome and I’ve learnt alot along the way. I think there may be some improvements to be had, so long as I understand the intent of the repo correctly.
I’m assuming that users will fork the repo along with also forking infrastructure-modules-acme, sample-app-frontend-acme and sample-app-backend-acme.
Let me know if i’ve misunderstood and if you’d accept a PR that could do all/some of:
- use of
${get_aws_account_id()}when generating terraform states3bucket names (to ensure global uniqueness) - use of variables for
github_org(to replacegruntwork.ioin all the module urls with the location of the forkedinfrastructure-modules-acme) - use of variables for
domain_namefor use inroute53entry creation - extended use of
replace-meto include thecidraddresses and account ids as well as theamis, so you can search the live settings repo and see if there are any more values that need to be changed, - default to empty for
ssh_key_nameand give explanation of how to generate this keypair - add to top level
READMEthe pre-requisite steps to take beforecd main && terragrunt apply-allwill work, e.g. replacing variables listed above, generatingamis, generating lambda function, setting env_var formaster_password…
Of course, it could just be me that hit these issues and needs things spelling out in more detail…